361_fix_training_greeting_ui #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadronCollider
requested changes
Jul 3, 2023
There was a problem hiding this comment.
Чтобы не парсить полную строку описания набора критериев предлагаю сделать новый метод для формирования описания (и возможно обновить такой метод у критериев)
https://github.com/OSLL/web_speech_trainer/blob/eeb619048204e2c19d17422fc9693eeae540e061/app/routes/trainings.py#L177C61-L177C61
и передавать его в html как json-encoded, чтобы в JS получать готовый объект, с которым можно работать
HadronCollider
requested changes
Jul 10, 2023
| "Критерий": t(self.name), | ||
| 'Описание':t('проверяет, что в речи нет слов-паразитов, используются слова из списка {}').format(self.parameters['fillers']), | ||
| 'Оценка':t('1, если слов-паразитов не больше {}, иначе 0').format(self.parameters['maximum_fillers_number']), | ||
| 'Вес':'' |
There was a problem hiding this comment.
"Вес" - не относится к описанию критериев, это часть конфигурации набора критериев, зачем он тут?
app/routes/trainings.py
Outdated
Comment on lines
129
to
150
|
|
||
| page = 0 | ||
| count = 10 | ||
|
|
||
| try: | ||
| page = int(request.args.get('page', '0')) | ||
| except: | ||
| pass | ||
|
|
||
| try: | ||
| count = int(request.args.get('count', '10')) | ||
| except: | ||
| pass | ||
|
|
||
| authorized = check_auth() is not None | ||
| if not (check_admin() or (authorized and session.get('session_id') == username)): | ||
| return {}, 404 | ||
| return render_template('show_all_trainings.html', username=username, full_name=full_name, is_admin="true" if check_admin() else 'false'), 200 | ||
|
|
||
| raw_filters = request.args.getlist('f') | ||
| filters_string = '&'.join(raw_filters) | ||
|
|
||
| return render_template('show_all_trainings.html', username=username, filters=filters_string, is_admin="true" if check_admin() else 'false', page=str(page), count=str(count)), 200 |
There was a problem hiding this comment.
Откуда и для чего тут эти изменения? (не похоже на вашу задачу, но похоже на чужую)
HadronCollider
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
До:
После: