Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag_changes field to Filters #619

Merged
merged 1 commit into from
May 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/components/filters/filters_list.js
Original file line number Diff line number Diff line change
Expand Up @@ -234,34 +234,41 @@ class FiltersList extends React.PureComponent<void, propsType, *> {
{filtersData
.slice(0, 5)
.map((f: Object, k) => this.renderFilters(f, k))}
<h2 className="txt-xl mr6 txt-bold mt30 border-b border--gray-light border--1">
OSM Features
</h2>
{filtersData
.slice(5, 6)
.map((f: Object, k) => this.renderFilters(f, k))}
<span className="flex-child flex-child--grow wmin420 wmax435" />
<h2 className="txt-xl mr6 txt-bold mt30 border-b border--gray-light border--1">
Flags
</h2>
{filtersData
.slice(5, 7)
.slice(6, 8)
.map((f: Object, k) => this.renderFilters(f, k))}
<span className="flex-child flex-child--grow wmin420 wmax435" />

<h2 className="txt-xl mr6 txt-bold mt30 border-b border--gray-light border--1">
Review
</h2>
{filtersData
.slice(7, 11)
.slice(8, 12)
.map((f: Object, k) => this.renderFilters(f, k))}
<span className="flex-child flex-child--grow wmin420 wmax435" />

<h2 className="txt-xl mr6 txt-bold mt30 border-b border--gray-light border--1">
Users & Teams
</h2>
{filtersData
.slice(11, 18)
.slice(12, 19)
.map((f: Object, k) => this.renderFilters(f, k))}
<span className="flex-child flex-child--grow wmin420 wmax435" />

<h2 className="txt-xl mr6 txt-bold mt30 border-b border--gray-light border--1">
Changeset Details
</h2>
{filtersData.slice(18).map((f: Object, k) => this.renderFilters(f, k))}
{filtersData.slice(19).map((f: Object, k) => this.renderFilters(f, k))}
<span className="flex-child flex-child--grow wmin420 wmax435" />
</div>
);
Expand Down
13 changes: 12 additions & 1 deletion src/config/filters.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,17 @@
"description": "Filter changesets that have a bbox area lower than X times the area of your BBox or geometry filter. For example, if the geometry you defined in your filter has an area of 1 degree and you set the 'BBox size bound' to 2, it will filter the changesets whose bbox area is lower than 2 degrees.",
"placeholder": "Upper bound of bbox area"
},
{
"name": "tag_changes",
"icontains": false,
"all": false,
"range": false,
"display": "OSM features tags",
"cache": true,
"type": "text_comma",
"description": "Filter changesets using OSM tag values. Example: highway=footway. Use an asterisk to filter any value for a key, example: amenity=*",
"placeholder": "building=yes, amenity=*, highway=primary"
},
{
"name": "is_suspect",
"icontains": false,
Expand Down Expand Up @@ -77,7 +88,7 @@
"data_url": "suspicion-reasons",
"display": "Reasons for Flagging",
"type": "text_comma",
"description": " Select one or multiple reasons that a changeset might be flagged for.",
"description": "Select one or multiple reasons that a changeset might be flagged for.",
"placeholder": "Start typing to pick reasons"
},
{
Expand Down