Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign courses phase 1 #220

Merged
merged 1 commit into from
May 11, 2024
Merged

Redesign courses phase 1 #220

merged 1 commit into from
May 11, 2024

Conversation

Durbin-Elijah
Copy link
Contributor

Cumulative changes from the past 2 weeks in the old redesign-course branch, fixed commit loop from basing off main.

Adds a component for displaying a page as a modal and uses it in the teacher landing for creating a new course

Screenshots

image

Description

Adds a component for displaying a page as a modal and uses it in the teacher landing for creating a new course.
Component is react and activated with a Button that acts as a normal HTML button with special properties.

Fixes # (issue)

Additional Information

I had to move the changes over from the old branch, I think I got everything right but please let me know any issues that may have been caused from this.

Feel free to comment if there is a better way to do this so we don't run into issues later after implementing the button in other pages.

If you notice something that should be commented let me know as well. I will continue to work in this branch for design changes getting ready for the expo presentation.

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • [*] I have added tests that prove my fix is effective or that my feature works.
  • [*] New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

*I don't think we have a testing system for frontend changes

… can display other components/pages within a modal.
@Durbin-Elijah Durbin-Elijah added the enhancement New feature or request label May 7, 2024
@Durbin-Elijah Durbin-Elijah requested a review from a team as a code owner May 7, 2024 23:38
Copy link
Member

@nilsstreedain nilsstreedain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial design looks good, may make minor changes along with the other design consolidation later

@nilsstreedain nilsstreedain added this pull request to the merge queue May 11, 2024
Merged via the queue into dev with commit d97e587 May 11, 2024
2 checks passed
@nilsstreedain nilsstreedain deleted the redesign-courses branch May 11, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants