Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cypress script #159

Open
6 tasks
UlisesGascon opened this issue Aug 6, 2019 · 5 comments
Open
6 tasks

Improve Cypress script #159

UlisesGascon opened this issue Aug 6, 2019 · 5 comments

Comments

@UlisesGascon
Copy link
Collaborator

Context

Tasks

  • Improve the speed of the e2e tests (almost 8 minutes now). Maybe videos are generated (ci/local envs)
  • Add test that are missing (fast check)
  • Remove unnecessary/repetitive tests
  • Improve the command dbReset. Missing validation due Travis conflicts
  • Check that the npm tasks are working as expected
  • Update the readme.md with the extra relevant info (if needed)

Assignation

  • This tasks is open for assignation, just claim it (as reply to this) and submit your PR ;-)

Important

@rcowsill
Copy link
Contributor

I'd like to help with this. I've been looking at some performance improvements to the tests and also making them more reliable.

@rcowsill
Copy link
Contributor

rcowsill commented Aug 11, 2020

To start, I'd like to make pull requests for two fixes that should resolve the signup test flakiness:

  • Make db-reset.js wait for dropCollections to complete before inserting new data
  • Set necessary env vars in docker-compose.yml to make the web service use the mongo service (instead of mongolab)

The first one affects branches master and feature/187. The second currently only affects feature/187, because master isn't using docker in Travis.

I have more to follow, but these are higher priority because they make the tests reliable. Making these changes should save a lot of time looking into false build failures.

@UlisesGascon, which branch(es) would you prefer the pull request(s) to be made against?

@rcowsill
Copy link
Contributor

Pull request for the dropCollections fix is open: #214

@rcowsill
Copy link
Contributor

rcowsill commented Nov 10, 2020

To start, I'd like to make pull requests for two fixes that should resolve the signup test flakiness:

Both these fixes were merged into master in c44bbd6.

The fix to set MONGODB_URI in docker builds needs to be merged into feature/187 before January 12, 2021. On that date the mLab database currently used by CI in this branch will be shut down, causing all subsequent Travis jobs to fail.

@rcowsill
Copy link
Contributor

Just made PR #230 which adds video recording/upload to the github actions CI workflow.

Video recording is off by default for local test runs, but can be activated like this if needed:
npm run test:ci -- --config video=true
or:
npx cypress run --config video=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants