Fix intermittent test failures #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collection drop commands were sent without waiting for their completion. The userId counter insert could complete before the counter collection drop. In that case the new counter would be deleted
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the cypress tests fail in CI when they should have passed. Rerunning the tests eventually gets them to go green, but that makes unnecessary work for the maintainers. The change in this PR fixes the main issue causing this problem in the master branch.
This issues affects all branches, but it's intermittent. The nodegoat service fails with:
All cypress tests fail after that point. For example: https://travis-ci.com/github/OWASP/NodeGoat/jobs/298947707
That happens because the db-reset script doesn't wait for the collection drop commands to complete before inserting new data. The command to insert the userId counter can run against the old collection, just before it gets deleted. The test then fails when nodegoat tries to add a user and can't get the userId counter.
21d5740 prevents that by waiting for all the collection drops to complete (or fail) before starting to insert new data. Sorry if the diff looks complex, the last ~50 lines is mainly just an extra level of indentation. It's much clearer with "hide whitespace changes" enabled.