Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to ES6 #185

Merged
merged 12 commits into from
Mar 17, 2020
Merged

Migration to ES6 #185

merged 12 commits into from
Mar 17, 2020

Conversation

UlisesGascon
Copy link
Collaborator

@UlisesGascon UlisesGascon commented Jan 29, 2020

Migration to ES6 🎉

Context:

Original issue: #152
Release Target: 1.5

Notes

  • This PR is an addition to many previous efforts. I just made a big step in this PR.
  • Most parts are now under a fresh JS Sintaxis! But not all of them
  • The missing parts are covered in separate PRs (like templates or Grunt) due migrations/deprecations, etc...
  • The logic can be better but we don't have yet unit testing and I don't want to refactor DAOs and routes before Unit tests are implemented (see Roadmap for 2019-2020 #148)
  • Upgraded docker images to v12 for testing (Docker compose) (See: e89dab4)

Changelog

@UlisesGascon UlisesGascon added this to the v1.5 milestone Jan 29, 2020
@UlisesGascon UlisesGascon self-assigned this Jan 29, 2020
@UlisesGascon UlisesGascon mentioned this pull request Jan 29, 2020
31 tasks
> Error-handling middleware always takes four arguments. You must provide four arguments to identify it as an error-handling middleware function. Even if you don’t need to use the next object, you must specify it to maintain the signature. Otherwise, the next object will be interpreted as regular middleware and will fail to handle errors.
see: https://expressjs.com/en/guide/using-middleware.html
@UlisesGascon
Copy link
Collaborator Author

Ready for review @lirantal @ckarande 👍

@UlisesGascon
Copy link
Collaborator Author

Merged due #187

@UlisesGascon UlisesGascon merged commit fd0d7e9 into OWASP:release-1.5 Mar 17, 2020
@UlisesGascon UlisesGascon deleted the feature-152 branch March 17, 2020 13:00
@UlisesGascon UlisesGascon mentioned this pull request Mar 17, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant