Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort sections on CRE page #289

Closed
robvanderveer opened this issue May 18, 2023 · 6 comments
Closed

Sort sections on CRE page #289

robvanderveer opened this issue May 18, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@robvanderveer
Copy link
Collaborator

Please sort each section on the CRE page, at least according to 'name' and if possible to 'name'+'section' because now NIST, ISO and ZAP entries are all mixed.

The key is in this code at CommonRequirementEnumeration.tsx

const linksByType = useMemo(() => (display ? orderLinksByType(groupLinksByType(display)) : {}), [display]);
return (

@northdpole northdpole added the good first issue Good for newcomers label Jun 8, 2023
@geekaryan
Copy link

Hello robvanderveer. I would like to work upon this issue. But I am having a trouble while cloning the repo I am getting this particular error.
error: invalid path 'cres/>>Authentication.yaml'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Can u help in figuring it out so I can contribute to the project.
Thank you

@robvanderveer
Copy link
Collaborator Author

robvanderveer commented Jun 13, 2023 via email

@northdpole
Copy link
Collaborator

Hey @geekaryan thanks for offering to contribute!
I'm having trouble reproducing your issue, are you on windows or macos?

@geekaryan
Copy link

Yes, sir I am on windows.
To reproduce the issue simple clone command.
git clone "repo link"

//It's refering that the issue is in Authentication.yml due toh some path issue. I hope this is helpful
Thank you

@northdpole
Copy link
Collaborator

This is because windows does not like the characters >> at the beginning of the filename.
Try: git checkout new_structure
the branch "new_structure" does not contain those CREs and it will be merged on the main branch next week so you should be able to work off of that

@geekaryan
Copy link

Thank you @northdpole for helping me out. Now I can run it in my local environment but not able to push the code as the main branch is still behind and as you have mentioned by next week I will able to create a pull request. Till then I will be very happy if I am able to fix more issues,

geekaryan added a commit to geekaryan/common-requirement-enumeration that referenced this issue Jun 14, 2023
Fixed issue OWASP#289 . I have added the functionality of sort using name and section in the desired page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants