Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network thread issue #359

Open
Ali-Razmjoo opened this issue Jul 22, 2022 · 2 comments
Open

network thread issue #359

Ali-Razmjoo opened this issue Jul 22, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Ali-Razmjoo
Copy link
Collaborator

two issues

  1. network thread is not terminating after an error
    to reproduce the issue, run a module, and then kill the container with docker kill container_name. OHP is expected to exit from working and throw an error, but the network thread stays open and it's not terminating.

  2. when I press ctrl+c to terminate the module, pcap file is not submitted to the database.

@Ali-Razmjoo Ali-Razmjoo added the bug Something isn't working label Jul 22, 2022
@spiderxm
Copy link
Collaborator

2. when I press ctrl+c to terminate the module, pcap file is not submitted to the database.

For this will need to add

except KeyboardInterrupt:
# break and return for stopping and removing containers/images
info(messages["interrupted_by_user"])
break
code here to push the pcap files to Elasticsearch in case of interrupt

@spiderxm
Copy link
Collaborator

spiderxm commented Aug 1, 2022

@Ali-Razmjoo, @dhirensr For issue 2, you must not have added the argument while running the containers.

sudo python3 ohp.py -m ftp/weak_password,ftp/strong_password --store-pcap

Add --store-pcap while starting the network capture process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants