fix - kill network capture process if any container is killed

[spiderxm]

Description

Fix network thread issue

Issue is network thread is not terminating after an error
to reproduce the issue, run a module, and then kill the container with docker kill container_name. OHP is expected to exit from working and throw an error, but the network thread stays open and it's not terminating.

Steps to Reproduce

# run the command below
$ sudo python3 ohp.py -m ftp/weak_password,ftp/strong_password --store-pcap
# wait until network capture process starts

# on new terminal run the command below
$ docker kill ohp_ftpserver_strong_password
# on the terminal where you started the capture process it will not end but it should.

Related Issue

#359

Screenshots (if appropriate):

After killing the container the network capture process terminates successfully.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Other

Checklist

• I have followed the Contributor Guidelines.
• The code has been thoroughly tested in my local development environment with flake8 and pylint.
• The code is Python 3 compatible.
• The code follows the PEP8 styling guidelines with 4 spaces indentation.
• This Pull Request relates to only one issue or only one feature
• I have referenced the corresponding issue number in my commit message
• I have added the relevant documentation.
• My branch is up-to-date with the Upstream master branch.

[dhirensr]

return in a while loop?

[spiderxm]

Return error("")
Is returning None

So we need to return True in failing cases

We can break the while loop and at the end return True
What say @dhirensr ?

[dhirensr]

we can't use break there. sounds like a use case for break?

[dhirensr]

this should do the job right without the above changes?

[spiderxm]

nopes, we need a exit flag value which denotes this has exited

[spiderxm]

@dhirensr check now