Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google authentication and Google Drive #1088

Closed
ericfitz opened this issue Sep 25, 2024 · 13 comments · Fixed by #1092
Closed

Add support for Google authentication and Google Drive #1088

ericfitz opened this issue Sep 25, 2024 · 13 comments · Fixed by #1092
Assignees
Labels
Milestone

Comments

@ericfitz
Copy link
Collaborator

ericfitz commented Sep 25, 2024

Describe what problem your feature request solves:
I would like to use the Threat Dragon tool in a non-GitHub environment. That means that I'd like to use Google Drive as a data store, and authenticate to the Threat Dragon application (and to Google Drive) using Google authentication.

Describe the solution you'd like:
I'd like to be able to configure an instance of Threat Dragon to use Google Sign-In, e.g. so I can authenticate as "[email protected]".

I'd also like to be able to configure an instance of Threat Dragon to use a Google Drive folder as a store for models, rather than a GitHub repo.

Additional context:
Related to issue 426

@ericfitz ericfitz added the enhancement New feature or request label Sep 25, 2024
@ericfitz
Copy link
Collaborator Author

ericfitz commented Sep 25, 2024

I've posted a $500 bounty (negotiable) for this issue.

@hasan-tec
Copy link

Thanks for sharing the details @ericfitz! I'd like to express interest in working on this feature enhancement for Google authentication and Drive integration.

To clarify, I'll implement Google OAuth 2.0 for sign-in, allowing users to authenticate via their Google accounts (e.g., "[email protected]"). I'll also set up Google Drive as a data store, enabling model files to be uploaded and managed in Drive rather than a GitHub repository.

Please feel free to provide any specific requirements or preferences regarding the integration. I'll review the codebase and propose an implementation approach. Let me know if there's any additional information you would like to share before I proceed.

Thanks!

@ericfitz
Copy link
Collaborator Author

ericfitz commented Sep 25, 2024

Thanks hasan-tec - you'll have to go through Upwork to get paid - the link to my job is here!

Basically I just want:

  1. A working, standard "sign in with Google" button that I can enable via configuration (and OAuth app registration with Google). Authentication needs to be done by Google (OAuth 2.0); we should not be collecting Google creds in the app.

  2. The ability to set configuration to allow/require Google Drive as a store for model files.

  3. A user experience to select the Google Drive folder in which to load/store models.

@jgadsden jgadsden added this to the Version 2.4 milestone Sep 26, 2024
@jgadsden
Copy link
Collaborator

Thank you @ericfitz for posting the bounty and raising this issue

@jgadsden
Copy link
Collaborator

@hasan-tec thank you for taking this on, version 2.3 is due out September 2024 (although this looks unlikely and may well be October) so I have tagged this with version 2.4 for you

@hasan-tec
Copy link

will i get paid for this? as it was in upworks job? 500$?

@ericfitz
Copy link
Collaborator Author

Hey Hasan-tec, I posted the bounty on upworks but have not hired a candidate yet. I am interviewing now. It's easy to pay through upworks. Do you have a way to chat?

@hasan-tec
Copy link

Yes you can, we have an agency on Upwork. You can come over to my agency, ByteForth, I have a professional team, you can hire us and then it will be easy for you to pay through Upwork. I have top 2 top rated Upwork freelancer and myself a rising talent on Upwork as well. The payment will be discussed there, don't worry it will be around 500, we don't overcharge, so don't worry about that. I will send you the link you can directly contaxt us, and then make a contract.

@hasan-tec
Copy link

@hasan-tec
Copy link

I have applied to your Upwork job post, and my team is ready for the interview anytime you want, and are really excited and ready for this job.

@hasan-tec
Copy link

@jgadsden you didnt had to unassign me, lmao, all g,

@hasan-tec
Copy link

Hiya Eric,
did you decline my Upwork job proposal?

@bryng001
Copy link
Collaborator

Hi Eric, here is an update of the progress:
9/27/24
What I did yesterday:
Added the google sign in feature using OAuth.
PR - #1092
What I will do today:
Will analyze the entire logic of this project and prepare to add Google Drive feature.
Roadblocks: No
Estimated completion: 35%
Project delivery status: Green

I don’t have any questions so far. Do let me know you if have additional requests. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants