Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support storage backends other than github #426

Open
danielpops opened this issue May 13, 2022 · 4 comments
Open

Support storage backends other than github #426

danielpops opened this issue May 13, 2022 · 4 comments
Assignees
Labels

Comments

@danielpops
Copy link
Collaborator

Describe what problem your feature request solves
Instead of using github repositories for storage of threat models, I'd like to store them all in an alternative centralized storage mechanism (I have a strong affinity to AWS, so s3 would be my preference)

Describe the solution you'd like
Introduce a storage mechanism configuration and support options like which cloud provider (aws, azure, google) and any relevant configuration options for each one (for AWS, this would probably just be bucket name and region). Of course, this introduces a new dependency on IAM credentials for the service, which I'd say is an exercise left to the reader (I'd personally launch threat-dragon as a containerized workload in AWS and attach an IAM role, but others assumedly would want to set AWS_ACCESS_KEY_ID etc.)

@danielpops danielpops added the enhancement New feature or request label May 13, 2022
@jgadsden
Copy link
Collaborator

Certainly sounds good to me - are you able to contribute time for this @danielpops (no harm in asking I hope)?

@danielpops
Copy link
Collaborator Author

@jgadsden honestly probably not in the very near future :) I'm definitely not up to speed yet on the overall codebase / design to propose a design for this, though I am very interested in the functionality.

@steve-winter
Copy link
Collaborator

Implementation should be very similar to #1 so I will progress a PR. Highlighting now so you can shut this down if you dont want it.

Intent is:

  1. New auth provider as 'AWS', which triggers the AWS OIDC - https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/sso-oidc/
  2. Once auth'd as AWS create a new repository and use the S3 client - https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/s3/

May need to 'default' the branch screen to show a generic branch equivalent, possibly use S3 versioning.

@jgadsden
Copy link
Collaborator

jgadsden commented Nov 25, 2023

excellent that you can work on this @steve-winter , thanks for taking this one on as well
I am sure the community would find this useful so it is still well worth implementing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants