Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N: add German translation #524

Closed
jgadsden opened this issue Sep 14, 2022 · 14 comments · Fixed by #713
Closed

I18N: add German translation #524

jgadsden opened this issue Sep 14, 2022 · 14 comments · Fixed by #713
Assignees
Labels
enhancement New feature or request I18N

Comments

@jgadsden
Copy link
Collaborator

Describe what problem your feature request solves
It would be good to have the German translation for Threat Dragon

Describe the solution you'd like
Modify translation file

Additional context

@jgadsden jgadsden added enhancement New feature or request I18N version-2.x labels Sep 14, 2022
@jgadsden jgadsden added help wanted Extra attention is needed good first issue and removed version-2.x labels Sep 25, 2022
@jgadsden jgadsden removed help wanted Extra attention is needed good first issue labels Oct 13, 2022
@jgadsden
Copy link
Collaborator Author

All yours if you would like to take this on @sparticvs

@sparticvs sparticvs self-assigned this Oct 21, 2022
@sparticvs
Copy link
Collaborator

@jgadsden I'm looking into this further, I think there is an assumption of English grammar in the structuring here - I'm looking into this further, but we may need to make some other adjustments to get a coherent German translation. I'll likely leave parts of this in English to purely support not needing any UI changes at the moment. I'm not 100% certain at the moment, so I'm still investigating this.

@jgadsden
Copy link
Collaborator Author

I am sure you are right; we can shuffle the text strings around, even combine and split them, if necessary. Feel free to do this if you need to and we can fix up the other translations to suit

@professorabhay
Copy link
Collaborator

Hey @jgadsden, Can I resolve this issue and merge PR after creating and close this also??👨🏻‍💻
Please explain it little more to me!!

@jgadsden
Copy link
Collaborator Author

jgadsden commented Dec 1, 2022

Hello @professorabhay , how good is your German language?
At present this is assigned to @sparticvs , so I would like to leave it with him

@professorabhay
Copy link
Collaborator

🥲 Not so good
Just basic but I can do it correctly 🤠

@sparticvs
Copy link
Collaborator

@professorabhay - Mochtest du die Veränderungen überprüfen?

@jgadsden - I've been working on this in my spare time, which has me slowed down with a new puppy and toddler in the mix. I've been also making sure that the wording is aligned with the threat modeling papers that have been published by students from German universities.

@professorabhay
Copy link
Collaborator

@sparticvs
Ya sicher !!

@jgadsden
Copy link
Collaborator Author

jgadsden commented Aug 2, 2023

@Zmiler you may want to work with @sparticvs on this tranlsation?

@Zmiler
Copy link
Contributor

Zmiler commented Aug 2, 2023

I would gladly help with translation. I am a native german speaker

@sparticvs
Copy link
Collaborator

I'll push up what I have completed ASAP if you want it.

@jgadsden how do you want the tracking done where the grammar doesn't work with the templating?

@jgadsden
Copy link
Collaborator Author

jgadsden commented Aug 3, 2023

ah, can you give an example @sparticvs ? I am not sure what you mean

@Zmiler
Copy link
Contributor

Zmiler commented Aug 4, 2023

@jgadsden I translated most of it. I did not see any weird text wrapping yet. I will translate the remaining bits tomorrow and check all areas of the application

Zmiler added a commit to Zmiler/threat-dragon that referenced this issue Aug 5, 2023
jgadsden pushed a commit to Zmiler/threat-dragon that referenced this issue Aug 5, 2023
jgadsden added a commit that referenced this issue Aug 5, 2023
@sparticvs
Copy link
Collaborator

@jgadsden my concern was with the break up of "select", "from", etc. Looking at @Zmiler's translation, there probably isn't an issue after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request I18N
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants