-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18N: add German translation #524
Comments
All yours if you would like to take this on @sparticvs |
@jgadsden I'm looking into this further, I think there is an assumption of English grammar in the structuring here - I'm looking into this further, but we may need to make some other adjustments to get a coherent German translation. I'll likely leave parts of this in English to purely support not needing any UI changes at the moment. I'm not 100% certain at the moment, so I'm still investigating this. |
I am sure you are right; we can shuffle the text strings around, even combine and split them, if necessary. Feel free to do this if you need to and we can fix up the other translations to suit |
Hey @jgadsden, Can I resolve this issue and merge PR after creating and close this also??👨🏻💻 |
Hello @professorabhay , how good is your German language? |
🥲 Not so good |
@professorabhay - Mochtest du die Veränderungen überprüfen? @jgadsden - I've been working on this in my spare time, which has me slowed down with a new puppy and toddler in the mix. I've been also making sure that the wording is aligned with the threat modeling papers that have been published by students from German universities. |
@sparticvs |
@Zmiler you may want to work with @sparticvs on this tranlsation? |
I would gladly help with translation. I am a native german speaker |
I'll push up what I have completed ASAP if you want it. @jgadsden how do you want the tracking done where the grammar doesn't work with the templating? |
ah, can you give an example @sparticvs ? I am not sure what you mean |
@jgadsden I translated most of it. I did not see any weird text wrapping yet. I will translate the remaining bits tomorrow and check all areas of the application |
Describe what problem your feature request solves
It would be good to have the German translation for Threat Dragon
Describe the solution you'd like
Modify translation file
Additional context
The text was updated successfully, but these errors were encountered: