generated from OWASP/www-projectchapter-example
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing broken URLs #290
Merged
Merged
Fixing broken URLs #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
added
the
404
An issue that outlines a 404 issue or a PR related to the fix for one
label
Oct 5, 2020
kingthorin
requested changes
Oct 5, 2020
pages/vulnerabilities/Information_exposure_through_query_strings_in_url.md
Outdated
Show resolved
Hide resolved
All changes made. Would you like me to squash the changes and push them as one commit? Will force push so that there's no need to re-create the PR. |
That'd be great, thanks! |
Co-authored-by: kingthorin <[email protected]>
Done. |
kingthorin
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks ⭐
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was going through pages, found plenty of broken references. Ran a broken URL checker against the website, found a lot of broken URLs. Fixed some of them, esp. where syntax was concerned, in addition to that, fixed or removed some broken internal references. Also, replaced
site.com
references (real site) withexample.org
. Some URLs remain broken:If anyone wants to go through these,
grep --color=always -nr -Ff broken_urls_left.txt|grep --color=always -v "broken_"|sort
will show where those URLs are specifically. Could probably also find a lot of broken internal references by looking for "wikilink".Please review before merge.