Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak: Added a check if the user already exists for the "oe:admin:c… #944

Open
wants to merge 2 commits into
base: b-7.0.x
Choose a base branch
from

Conversation

oxidMichaelWalter
Copy link

Tweak: Added a check if the user already exists for the "oe:admin:create" command

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2024

CLA assistant check
All committers have signed the CLA.

@Sieg
Copy link
Member

Sieg commented Mar 18, 2024

Hey, @oxidMichaelWalter, need some rework here:

  • In Dao, if we could be not so specific, we could use the method for more cases, how about making a method with the name getAdminUserByEmail or even better getByEmail as it already have "create"?
  • Instead of checking for user existence in the AdminFactory (and EXIT? you cannot use exit), let's check for user existence in the command itself, near email validation maybe, and we could use getByEmail for this check.
  • Also, where are the tests? ;) will not work for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants