Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk to v0.2.11 #94

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Update sdk to v0.2.11 #94

merged 2 commits into from
Aug 30, 2019

Conversation

ethanbennett
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 23, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://mcd-cdp-portal-git-mcd-v0211.mkr-js-prod.now.sh

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #94 into develop will increase coverage by 1.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #94      +/-   ##
===========================================
+ Coverage    29.77%   30.94%   +1.16%     
===========================================
  Files          110      116       +6     
  Lines         1951     2146     +195     
===========================================
+ Hits           581      664      +83     
- Misses        1370     1482     +112
Impacted Files Coverage Δ
src/utils/units.js 41.66% <0%> (-8.34%) ⬇️
src/reducers/cdps.js 79.71% <0%> (-7.39%) ⬇️
src/reducers/feeds.js 56.81% <0%> (-3.19%) ⬇️
src/providers/MakerProvider.js 43.24% <0%> (-1.21%) ⬇️
src/reducers/index.js 0% <0%> (ø) ⬆️
...mponents/CDPCreateScreens/CDPCreateSetAllowance.js 0% <0%> (ø) ⬆️
...ents/CDPCreateScreens/CDPCreateSelectCollateral.js 0% <0%> (ø) ⬆️
src/routes.js 0% <0%> (ø) ⬆️
src/components/AccountBox.js 100% <0%> (ø) ⬆️
src/hooks/useWalletBalances.js 100% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64dfac4...88c7656. Read the comment docs.

Copy link
Contributor

@tyler17 tyler17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyler17
Copy link
Contributor

tyler17 commented Aug 27, 2019

Regarding the failing test on Travis, I wasn't able to reproduce it until I installed codecov as is done in the travis.yml with npm install -g codecov. Now I'm getting the same error locally, which seems very weird...but a temporary fix could be install codecov after yarn ci but before codecov in travis
edit: actually, it still fails when running codecov after yarn ci, and now its working for me locally with codecov installed, so it must just be a bug that only fails sometimes.
Created a JIRA ticket for it: https://makerdao.atlassian.net/secure/RapidBoard.jspa?rapidView=57&modal=detail&selectedIssue=CDP-413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants