cmd: broadcast all exits #3288
cmd: broadcast all exits #3288
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3288 +/- ##
==========================================
- Coverage 57.65% 57.63% -0.02%
==========================================
Files 211 211
Lines 30480 30569 +89
==========================================
+ Hits 17572 17619 +47
- Misses 11010 11049 +39
- Partials 1898 1901 +3 ☔ View full report in Codecov by Sentry. |
| return errors.Wrap(err, "exit message signature not verified") | ||
| } | ||
|
|
||
| if err := eth2Cl.SubmitVoluntaryExit(valCtx, &fullExit); err != nil { |
There was a problem hiding this comment.
We may exhaust the BN here on some big clusters. I'm thinking of ways to prevent that and I'm open to suggestions.
There was a problem hiding this comment.
I think a simple delay (maybe 100ms) should be safe enough? Otherwise NOP shall tweak rate limiting on its BN.
There was a problem hiding this comment.
@gsora any view on that? I think of maybe adding a flag of type "be-gentle-with-bn" that adds some delay between broadcasts :)
There was a problem hiding this comment.
Hm, to be fair I've never seen a BN choke under lots of voluntary exits.
@OisinKyne do you think this could be a concern?
|
KaloyanTanev
added
the
merge when ready
Second part of adding the
--allflag for exits.This PR is for the
charon exit broadcastcommand. Additionally, a flagexitFromDiris introduced so point to a directory with exit files.category: feature
ticket: #3243