Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use logger #394

Closed
Naamloos opened this issue Nov 15, 2023 · 0 comments · Fixed by #416
Closed

Properly use logger #394

Naamloos opened this issue Nov 15, 2023 · 0 comments · Fixed by #416
Labels
code-style Relates to code formatting and conventions epic Very cool good first issue Good for newcomers priority: low Nice to have sir we are a minecraft server not the markdown editor

Comments

@Naamloos
Copy link
Member

Naamloos commented Nov 15, 2023

In some cases, Obsidian improperly uses string formatting with the logger.

As of right now, it would use the following formatting:

Logger.LogDebug($"Sent Login success to user {Player.Username} {Player.Uuid}");

This should be

Logger.LogDebug("Sent Login success to user {Username} {UUID}", Player.Username, Player.Uuid);

Now, this given example is already fixed but I am sure there may be more cases of it being incorrect.

@Naamloos Naamloos added good first issue Good for newcomers epic Very cool priority: low Nice to have code-style Relates to code formatting and conventions sir we are a minecraft server not the markdown editor labels Nov 15, 2023
@Tides Tides moved this to Backlog in Obsidian Tracker Jan 21, 2024
@Tides Tides moved this from Backlog to Ready in Obsidian Tracker Jan 21, 2024
Craftplacer pushed a commit that referenced this issue Jan 21, 2024
Properly use logger
closes #394
@github-project-automation github-project-automation bot moved this from Ready to Done in Obsidian Tracker Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-style Relates to code formatting and conventions epic Very cool good first issue Good for newcomers priority: low Nice to have sir we are a minecraft server not the markdown editor
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant