Migrate to use Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets
#387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonpro03
previously approved these changes
Aug 22, 2023
Naamloos
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Obsidian uses the
TcpListenerfor the server and rawSocketfor the client. While those classes do the job, the issue #96 raises a concern about performance due to the fact that the currently used classes do not make use of the optimized ways for data receiving and sending. I benchmarked the login state sequence, before using the PR and after. The server averaged at 841140 ticks after the PR, and 934719 ticks before. (Results are not 100% accurate), it can also be significantly improved if we start usingSystem.IO.Pipelines, and this PR is a step towards that.