Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #251 & #418 #420

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Fixes #251 & #418 #420

merged 3 commits into from
Jan 22, 2024

Conversation

TheVeryStarlk
Copy link
Contributor

(I dunno how I can separate each commit to a different PR)

connection = acceptedConnection;

if (!_isFullyInitialized)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use WorldManager.ReadyToJoin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now 😄

@Naamloos
Copy link
Member

420 blaze it

Copy link
Member

@Naamloos Naamloos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from tides' requested change this looks fine

@Tides Tides merged commit 6efa497 into ObsidianMC:master Jan 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants