Fixes #426 #428
Merged
Fixes #426 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naamloos
reviewed
Feb 22, 2024
Craftplacer
previously approved these changes
Feb 23, 2024
| public byte ViewDistance | ||
| { | ||
| get => viewDistance; | ||
| set => viewDistance = value >= 3 ? value : (byte) 3; |
There was a problem hiding this comment.
Consider a const variable for 3
Naamloos
previously approved these changes
Feb 23, 2024
TheVeryStarlk
dismissed stale reviews from Naamloos and Craftplacer
via
9227f37
Naamloos
approved these changes
Feb 23, 2024
|
Just gonna go ahead and merge this since all issues have been resolved and this looks fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.