Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement player abilities packet #433

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

TheVeryStarlk
Copy link
Contributor

No description provided.

Craftplacer
Craftplacer previously approved these changes Feb 28, 2024
Copy link
Collaborator

@Craftplacer Craftplacer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but doesn't seem possible to update after first packet has been sent.

@TheVeryStarlk
Copy link
Contributor Author

Looks fine, but doesn't seem possible to update after first packet has been sent.

Yes because apparently the server should send this instead

Copy link
Member

@Tides Tides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@@ -0,0 +1,11 @@
namespace Obsidian.API._Types;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I merge fix pls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now?

@Tides Tides merged commit 4ce9755 into ObsidianMC:master Mar 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants