Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating latitude and longitude variables long name #237

Closed
jenseva opened this issue May 31, 2024 · 8 comments
Closed

Consider updating latitude and longitude variables long name #237

jenseva opened this issue May 31, 2024 · 8 comments
Assignees
Labels
1.0 For stuff that must be resolved before we are able to release 1.0

Comments

@jenseva
Copy link
Collaborator

jenseva commented May 31, 2024

Proponent(s): @jenseva

Moderator: @OceanGlidersCommunity/format-maintainers

I noticed that the long name for latitude and longitude variables looks incorrect.

It currently is spec'd as, "latitude of each measurement and GPS location", but this is not true for underwater gliders. I recommend using something like: "Estimated Subsurface Latitude of Each Measurement" instead.

Platforms affected
All.

Additional context
I've started including a comment attribute on the subsurface position variables attempting to describe the inaccuracy and that these latitudes are estimated based on surface GPS measurements before and after the dive.

@jenseva jenseva self-assigned this May 31, 2024
@emmerbodc
Copy link
Collaborator

They do also include the GPS locations so I think we should keep that part in the long name unless others disagree.

@vturpin
Copy link
Member

vturpin commented Jun 3, 2024

I do agree with Emma, measurement are also made during surfacing. So we need to make clear this is not only estimated by also GPS.

I also think the definition of Jen is more precise.

So i will suggest a mix of both ?

Would "Estimated Subsurface Latitude of Each Measurement and GPS location" be acceptable ?

@emmerbodc
Copy link
Collaborator

agreed in meeting yesterday to follow vocabulary preferable label for the long name string.

@jenseva
Copy link
Collaborator Author

jenseva commented Jun 7, 2024

Sorry I haven't been able to attend the meetings due to my time zone. Can you please explain the resolution?

FWIW, a spray glider will never have a GPS measurement that is coincident with geophysical measurements because sampling is stopped during GPS fixes.

For this variable, with our gliders the locations will all be calculated, there will be no GPS positions.

Can there be flexibility in the long name for use cases like ours?

@vturpin
Copy link
Member

vturpin commented Jun 7, 2024

Yes what Emma suggest will solve that case.
vocab pref long name is "Latitude north (WGS84)"
see definition: http://vocab.nerc.ac.uk/collection/OG1/current/LAT/
And we will link this variable to the vocab.

This definition doesn't bring any confusion I think. It can be Latitude from GPS or calculated latitude doesn't mater here. Is it acceptable for you @jenseva ?

@emmerbodc are you in charge of this PR ?

Does it sound good for you @jenseva

@vturpin vturpin added the 1.0 For stuff that must be resolved before we are able to release 1.0 label Jun 7, 2024
@jenseva
Copy link
Collaborator Author

jenseva commented Jun 7, 2024

Great, thank you for clarifying @vturpin!

@jenseva jenseva closed this as completed Jun 7, 2024
@jenseva
Copy link
Collaborator Author

jenseva commented Jun 7, 2024

Oops, I'll wait to close this, so you can have it for your resolution/PR.

@callumrollo
Copy link
Member

Thanks for raising @jenseva! Resloved in #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 For stuff that must be resolved before we are able to release 1.0
Projects
None yet
Development

No branches or pull requests

4 participants