Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ids to phase variables.md #230

Merged
merged 1 commit into from
May 28, 2024
Merged

Add ids to phase variables.md #230

merged 1 commit into from
May 28, 2024

Conversation

vturpin
Copy link
Member

@vturpin vturpin commented May 24, 2024

related to #226

Proponents:
Moderator: @OceanGlidersCommunity/format-mantainers

Type of PR

  • Typo without possible change of interpretation of the related text.
  • Fix of some error, inconsistency, unforeseen limitation.
  • Style that only affects visually the compiled document
  • Addition that does not require change in the current structure.
  • Enhancement that require changes to improve the format.

Related Issues

Dates when it got review approvals

Release checklist

  • Approved by at least two members of the committee?
  • There were modifications after the review approvals? If so, please
    ask reviewers to update their review.
  • Proponents and moderador should explicitly agree that it is ready to
    to merge.
  • The moderador is the one in charge to actually merge or close this PR
    according to the final decision.

For maintainers

  • Update the moderator with a volunteer from the committee. It would be
    best to have one single moderator to guide and help this PR to move
    forward. It is OK to update the moderador pass it to another one.
  • Confirm that the associated branch was deleted after the merging.
  • Wrap-up and close the related issues.

Comments

@vturpin vturpin added the 1.0 For stuff that must be resolved before we are able to release 1.0 label May 24, 2024
@emmerbodc emmerbodc merged commit 0723eb4 into main May 28, 2024
@emmerbodc emmerbodc deleted the vturpin-patch-11 branch May 28, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 For stuff that must be resolved before we are able to release 1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants