Further accessibility improvements: label regions, hide temperature graph, add necessary headings #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
targets master
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automatic PR Validation failed
There were one or more problems detected with this PR:
- The PR's target branch
masteris not among the allowed target branches: maintenance, devel, staging/bugfix, staging/maintenance, staging/devel. Please only create PRs against these.
Please take a look at the Contribution Guidelines of this repository and make sure that the PR follows them. Thank you!
I'm just a bot 🤖 that does automatic checks, a human will intervene if I've made a mistake.
|
Thank you very much! |
foosel
removed
needs some work
foosel
added a commit
that referenced
this pull request
Feb 12, 2024
They are causing issues with third party plugins, and the proper roles and labels should provider the same and hopefully even better functionality. Update of #4928, see also LazeMSS/OctoPrint-UICustomizer#315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
With PR #4597 accessibility labels were added to links and buttons, thus making OctoPrint basically accessible.
This PR adds some improvements to the accessibility:
How was it tested? How can it be tested by the reviewer?
Tested using NVDA screenreader on Windows, Voice Over on Mac and iOS.
Any background context you want to provide?
N/A
What are the relevant tickets if any?
N/A
Screenshots (if appropriate)
N/A
Further notes
N/A