Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/octoprint/octoprint
and/octoprint/plugins
folders explicitly during docker build--basedir /octoprint/octoprint
instead of just/octoprint
config-editor
container tooctoprint:/octoprint
BREAKING CHANGES This may be a breaking change for existing users that are using a volume mounting strategy other than the recommended strategy, thus will constitue a new major release for the image.
Where before the root context of the volume mount looked like this:
It will now look like this:
Note: the
/octoprint/plugins
directory is the python libraries path, and/octoprint/octoprint/plugins
is the path for plugin data and configuration. Prior to this change, both of these things existed in the/octoprint/plugins
folder, polluting it's purpose.This new method will allow savvy users to create distinct volumes for plugin binaries and octoprint configuration data, givinig them more ability to selectively control how state and memory consumption are utilized in their octoprint image usage/distribution strategies.