Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
Jenkins - Queue Job
did not have the option to wait until the job had completed. It had the option to specify a timeout value, but not something that would wait until it reported it was no long building. In addition, I've updated the label and help text of theFail build
(now updated toFail deployment
) as it was confusing as to what the option was for. Evaluating the code showed that the intention was to fail the deployment if aSUCCESS
status was not returned. If a timeout occurred, the response was empty. I've also added warning to the code that will state that a timeout occurred before a response was received.Results
Users did not have the ability to simply wait for the build to complete.
Before
There wasn't an option to wait for a build to complete, only specify a timeout value.
After
Users can not check a box to wait for a build to go until completion.
Pre-requisites
Id
should be a GUID that is not00000000-0000-0000-0000-000000000000
Id
property (updating theId
will break the Library sync functionality in Octopus).Version
should be incremented, otherwise the integration with Octopus won't update the step template correctly$
LastModifiedBy
field must be present, and (optionally) updated with the correct authorCategory
has been created:{categoryname}.png
must be present under thestep-templates/logos
folderswitch
in thehumanize
function ingulpfile.babel.js
must have acase
statement corresponding to it