Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target WASM MVP spec for rust builds #2546

Merged
merged 14 commits into from
Aug 2, 2024
Merged

Conversation

PlasmaPower
Copy link
Collaborator

@PlasmaPower PlasmaPower commented Aug 1, 2024

This is an alternative to #2544 that doesn't require pinning an old rust version.

Adding the rust flag -C target-cpu=mvp seems to be good enough to prevent reference types from being generated in our use case.

Pulls in OffchainLabs/stylus-sdk-bf#7

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Aug 1, 2024
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 816a6d9 into master Aug 2, 2024
15 checks passed
@PlasmaPower PlasmaPower deleted the rust-target-wasm-mvp branch August 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants