Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fast confirmer config #2547

Merged
merged 11 commits into from
Aug 13, 2024
Merged

Remove fast confirmer config #2547

merged 11 commits into from
Aug 13, 2024

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Aug 1, 2024 •
edited
Loading

Based on harry's suggestion removing the dependency on config for fast confirmation, we can just fetch all the info from on chain.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Aug 1, 2024
@amsanghi amsanghi marked this pull request as ready for review August 1, 2024 17:46
PlasmaPower
PlasmaPower requested changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but I think we should still have a config option to enable/disable fast confirmations if desired. Let's default it to true, and it only takes effect if fast confirmations are enabled on-chain.

staker/staker.go Outdated Show resolved Hide resolved
@amsanghi
Copy link
Contributor Author

amsanghi commented Aug 1, 2024

Looks reasonable to me, but I think we should still have a config option to enable/disable fast confirmations if desired. Let's default it to true, and it only takes effect if fast confirmations are enabled on-chain.

Done

PlasmaPower
PlasmaPower reviewed Aug 6, 2024
View reviewed changes
staker/staker.go Outdated Show resolved Hide resolved
PlasmaPower
PlasmaPower reviewed Aug 7, 2024
View reviewed changes
staker/staker.go Outdated Show resolved Hide resolved
PlasmaPower
PlasmaPower approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 3031234 into master Aug 13, 2024
14 checks passed
@PlasmaPower PlasmaPower deleted the remove_fast_config_ branch August 13, 2024 22:51
@PlasmaPower PlasmaPower mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amsanghi @PlasmaPower