Fix a bug with odd-length resize calls #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljobe
requested review from
diegoximenes,
PlasmaPower,
joshuacolvin0 and
amsanghi
cla-bot
bot
added
the
s
|
LGTM but I think you accidentally reverted the recent nitro-testnode submodule pin in this PR |
The dirty_parents bitvec was not being resized correctly when the leaves were resized to an odd length. This PR adds tests and the fix.
|
Yup. I just force-pushed a different commit without the nitro-testnode submodule pin regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dirty_parents bitvec was not being resized correctly when the leaves were resized to an odd length.
This PR adds tests and the fix.