[config change] Support multiple producers in redis streams #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
ganeshvanahalli
requested review from
diegoximenes,
eljobe,
magicxyyz and
tsahee
eljobe
previously approved these changes
Aug 20, 2024
magicxyyz
requested changes
Aug 20, 2024
magicxyyz
reviewed
Aug 21, 2024
…rect request scenario
magicxyyz
reviewed
Aug 27, 2024
magicxyyz
previously requested changes
Aug 29, 2024
tsahee
reviewed
Sep 13, 2024
tsahee
requested changes
Sep 26, 2024
ganeshvanahalli
changed the title
ganeshvanahalli
changed the title
tsahee
previously approved these changes
Oct 7, 2024
| } | ||
| if _, err := p.client.XDel(ctx, p.redisStream, pelData.Lower).Result(); err != nil { | ||
| log.Error("error deleting PEL's lower message thats past its TTL", "msgID", pelData.Lower, "err", err) | ||
| } |
There was a problem hiding this comment.
return 0 here, so we'll immediately keep clearing old results as long as these exit
There was a problem hiding this comment.
I meant return 0 after the delete succeeded, if err != nil, so we'd immediately be called again because there's a good chance there are more messages that need to be deleted.
In case of errors above it makes sense to return non-zero for backoff.
tsahee
approved these changes
Oct 9, 2024
| } | ||
| if _, err := p.client.XDel(ctx, p.redisStream, pelData.Lower).Result(); err != nil { | ||
| log.Error("error deleting PEL's lower message thats past its TTL", "msgID", pelData.Lower, "err", err) | ||
| } |
There was a problem hiding this comment.
I meant return 0 after the delete succeeded, if err != nil, so we'd immediately be called again because there's a good chance there are more messages that need to be deleted.
In case of errors above it makes sense to return non-zero for backoff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows our redis stream pub-sub implementation to support multiple producers per stream.
Motivation for this change is that previously only one producer was supported per stream I.e although two producers were “technically” allowed to connect to a same redis stream, they couldn’t take any meaningful use of it i.e a producer could accidentally delete the requests from other producers etc..
Previously each consumer used to maintain a heartbeat key in redis and set it periodically to confirm being active, these keys were used by producer to determine what messages are stuck in PEL (pending entry list- messages that are claimed by a consumer but not yet acknowledged) and reinsert them into stream. This PR simplifies this whole process by using XAUTOCLAIM that automatically lets any consumer claim a message which belongs to PEL and is idle for a minimum amount of time.
Config Changes
request-timeouthas been added toProducerConfig- indicating TTL for each message added to the redis streamidletime-to-autoclaimhas been added toConsumerConfig- indicating amount of time after which a message from PEL is allowed to be autoclaimed by other consumersenable-reproduce,check-pending-interval,keepalive-timeoutandcheck-pending-itemshave been removed fromProducerConfig- as they are no longer needed due to changes in the working logic of producer & consumerkeepalive-timeouthas been removed fromConsumerConfigTesting Done
Various test cases covering different scenarios have been added to test the working of this design
Resolves NIT-2685