Fix data poster replace-by-fee loop #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of issues here, but most notably the "Don't try to send more than 1 unsent transaction" case had a significant issue. If the data poster gets into a situation where there's multiple queued unsent txs, it'd only try to send one every 5 minutes, because the default nextCheck is 5 minutes in the future, and it'd only try to send one of them at once.
This PR fixes that by reloading the tx from the queue after attempting to send or replace it. Then, it determines if it can continue trying to send future txs or if it needs to retry because it failed to send the current one.
Fixes NIT-2737