Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove parent-chain.wallet from config dump #2592

Merged
merged 2 commits into from
Aug 19, 2024
Merged

remove parent-chain.wallet from config dump #2592

merged 2 commits into from
Aug 19, 2024

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Aug 19, 2024

Resolves NIT-2738

parent-chain.wallet config option was removed in #2381

This PR removes clearing of outdated parent-chain.wallet.password and parent-chain.wallet.private-key when dumping a config.

Instead, the PR adds clearing of:

  • node.batch-poster.parent-chain-wallet.password
  • node.batch-poster.parent-chain-wallet.private-key
  • node.staker.parent-chain.wallet.password
  • node.staker.parent-chain.wallet.private-key

--parent-chain.wallet config option was removed in 0a81b9b
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Aug 19, 2024
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit 0cde181 into master Aug 19, 2024
14 checks passed
@tsahee tsahee deleted the fix-dump-config branch August 19, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants