Re-enable G115 overflowing integer casts lint #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
PlasmaPower
changed the title
PlasmaPower
changed the title
gligneul
reviewed
Aug 21, 2024
das/s3_storage_service.go
Outdated
| @@ -110,7 +111,8 @@ func (s3s *S3StorageService) Put(ctx context.Context, value []byte, timeout uint | |||
| Bucket: aws.String(s3s.bucket), | |||
| Key: aws.String(s3s.objectPrefix + EncodeStorageServiceKey(dastree.Hash(value))), | |||
| Body: bytes.NewReader(value)} | |||
| if !s3s.discardAfterTimeout { | |||
| if !s3s.discardAfterTimeout && timeout <= math.MaxInt64 { | |||
There was a problem hiding this comment.
Is this change on purpose? nvm
There was a problem hiding this comment.
It's currently backwards, fixed in #2600
Edit: I've merged that PR to master, and merged master into this one, so it's the right way around now
gligneul
previously approved these changes
Aug 21, 2024
gligneul
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NIT-2741
Largely, this PR just fixes ignores the lint at the sites where the issues otherwise occur (e.g. metrics updates, block timestamps, and block numbers) but this PR does sometimes fix or improve casts where I'm confident it doesn't change consensus and is cleaner.