-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NIT-2774] Enable external-signer for batch-poster with DA #2669
Conversation
When running a batch-poster with anytrust, Nitro needs to load the batch-poster parent-chain wallet config to sign the DA messages even if an external signer is also being used.
Since this change is on a configuration on the nitro binary, it doesn't make sense to add a system test. I will test it manually with the nitro test node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tested this on the nitro test node using the code in the Anytrust PR and a mock external signer that I hacked based on the external signer unit test. In this configuration, I set both the I also created a follow-up ticket on Linear to add an external-signer option to the nitro test node. |
When running a batch-poster with anytrust, Nitro needs to load the batch-poster parent-chain wallet config to sign the DA messages even if an external signer is also being used.
Close NIT-2774