Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-2852] Add flags and other info for nitro --dev #2751

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Oct 23, 2024

Fixes: NIT-2852

Add flags by default when working with --dev:
--http.api=net,web3,eth,arb,arbdebug,debug

When using a dev-init for the chain:

Add a dev-init flag setting maximum contract size in chain-config

set the dev-user as chain-owner

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 23, 2024
@amsanghi amsanghi marked this pull request as ready for review October 23, 2024 06:21
@amsanghi amsanghi requested a review from tsahee November 5, 2024 12:00
@@ -681,6 +681,7 @@ func openInitializeChainDb(ctx context.Context, stack *node.Node, config *NodeCo
Nonce: 0,
},
},
ChainOwner: common.HexToAddress(config.Init.DevInitAddress),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice solution!

Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge November 7, 2024 20:44
@tsahee tsahee merged commit 54c4115 into master Nov 7, 2024
15 checks passed
@tsahee tsahee deleted the dev_flag branch November 7, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants