Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update the manfiest file path in update aad app #8435

Merged
merged 3 commits into from
May 4, 2023
Merged

fix: update the manfiest file path in update aad app #8435

merged 3 commits into from
May 4, 2023

Conversation

wenytang-ms
Copy link
Contributor

@codecov
Copy link

codecov bot commented Apr 18, 2023 •
edited
Loading

Codecov Report

Merging #8435 (5b9c531) into dev (ed8fcb5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8435   +/-   ##
=======================================
  Coverage   78.64%   78.64%           
=======================================
  Files         614      614           
  Lines       41928    41928           
  Branches     8315     8315           
=======================================
  Hits        32973    32973           
  Misses       5616     5616           
  Partials     3339     3339
Impacted Files Coverage Δ
packages/cli/src/constants.ts 100.00% <100.00%> (ø)
packages/fx-core/src/core/question.ts 78.11% <100.00%> (ø)

Alive-Fish
Alive-Fish previously approved these changes Apr 19, 2023
View reviewed changes
hund030
hund030 previously approved these changes Apr 19, 2023
View reviewed changes
@wenytang-ms wenytang-ms dismissed stale reviews from hund030 and Alive-Fish via 5b9c531 April 19, 2023 02:18
@wenytang-ms wenytang-ms merged commit 4e60425 into dev May 4, 2023
@wenytang-ms wenytang-ms deleted the wenyt/aad branch May 4, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alive-Fish Alive-Fish Alive-Fish approved these changes

@hund030 hund030 hund030 approved these changes

@jayzhang jayzhang Awaiting requested review from jayzhang jayzhang is a code owner

@LongOddCode LongOddCode Awaiting requested review from LongOddCode LongOddCode is a code owner

@1yefuwang1 1yefuwang1 Awaiting requested review from 1yefuwang1

@nliu-ms nliu-ms Awaiting requested review from nliu-ms nliu-ms is a code owner

@xzf0587 xzf0587 Awaiting requested review from xzf0587 xzf0587 is a code owner

@chagong chagong Awaiting requested review from chagong chagong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenytang-ms @Alive-Fish @hund030