Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): improve validation help message #9725

Merged
merged 9 commits into from
Aug 25, 2023
Merged

fix(cli): improve validation help message #9725

merged 9 commits into from
Aug 25, 2023

Conversation

jayzhang
Copy link
Member

@jayzhang jayzhang commented Aug 25, 2023

  1. fix: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/24944869
  2. refactor: remove QTreeNode class and related codes
  3. move validation codes from api to fx-core

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@e1ef8a0). Click here to learn what that means.
The diff coverage is 90.59%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #9725   +/-   ##
======================================
  Coverage       ?   85.23%           
======================================
  Files          ?      440           
  Lines          ?    24910           
  Branches       ?     4716           
======================================
  Hits           ?    21233           
  Misses         ?     1951           
  Partials       ?     1726           
Files Changed Coverage Δ
packages/cli/src/utils.ts 93.81% <ø> (ø)
...core/src/component/middleware/actionExecutionMW.ts 69.35% <ø> (ø)
packages/fx-core/src/question/other.ts 81.78% <ø> (ø)
packages/fx-core/src/ui/validationUtils.ts 90.13% <88.88%> (ø)
packages/cli/src/constants.ts 100.00% <100.00%> (ø)
packages/cli/src/questionUtils.ts 72.72% <100.00%> (ø)
packages/fx-core/src/core/FxCore.ts 86.49% <100.00%> (ø)
packages/fx-core/src/index.ts 100.00% <100.00%> (ø)
packages/fx-core/src/ui/visitor.ts 85.02% <100.00%> (ø)
packages/server/src/serverConnection.ts 83.10% <100.00%> (ø)

@jayzhang jayzhang merged commit 28597af into dev Aug 25, 2023
19 checks passed
@jayzhang jayzhang deleted the huajie/validation branch August 25, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants