docs: update contribute guide doc to node.js 18 #9730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenytang-ms
requested review from
jayzhang,
LongOddCode,
adashen,
blackchoey,
tecton,
SLdragon,
yiqing-zhao,
1yefuwang1,
nliu-ms,
chagong,
Alive-Fish,
1openwindow and
HuihuiWu-Microsoft
as code owners
wenytang-ms
commented
Aug 25, 2023
| <table> | ||
| <tr> | ||
| <td><img src="https://raw.githubusercontent.com/OfficeDev/TeamsFx/main/packages/vscode-extension/media/landingPage_nodejs.png"></td> |
There was a problem hiding this comment.
the image link is invalid, so removed.
Alive-Fish
previously approved these changes
Aug 25, 2023
1yefuwang1
previously approved these changes
Aug 25, 2023
tecton
reviewed
Aug 25, 2023
wenytang-ms
dismissed stale reviews from 1yefuwang1 and Alive-Fish
via
5d95226
HuihuiWu-Microsoft
previously approved these changes
Aug 25, 2023
jayzhang
previously approved these changes
Aug 25, 2023
wenytang-ms
dismissed stale reviews from jayzhang and HuihuiWu-Microsoft
via
6127c74
blackchoey
previously approved these changes
Aug 25, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #9730 +/- ##
==========================================
+ Coverage 85.23% 85.26% +0.02%
==========================================
Files 440 440
Lines 24910 24929 +19
Branches 4716 4718 +2
==========================================
+ Hits 21233 21255 +22
+ Misses 1951 1950 -1
+ Partials 1726 1724 -2 |
blackchoey
approved these changes
Aug 28, 2023
tecton
approved these changes
Aug 28, 2023
Alive-Fish
approved these changes
Aug 28, 2023
jayzhang
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.