Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQ] nl.hardware.info #194

Closed
OhMyGuus-Bot opened this issue Oct 25, 2022 · 2 comments · Fixed by #198
Closed

[REQ] nl.hardware.info #194

OhMyGuus-Bot opened this issue Oct 25, 2022 · 2 comments · Fixed by #198
Assignees
@OhMyGuus
Labels
Anonymous request Requested using the bot Website request

Comments

@OhMyGuus-Bot
Copy link
Collaborator

Someone reported anonymously:

Website URL

https://nl.hardware.info

What browser are u using?

Firefox 106

Version

1.0.7

Notes
@appeasementPolitik appeasementPolitik mentioned this issue Oct 25, 2022
Merged
@ghost
Copy link

ghost commented Oct 25, 2022

Works for me ...

@OhMyGuus
Copy link
Owner

Merged a fix for this PR be aware Youtube embeds aren't enabled by default at the moment but the website has easy access to the cookie consent to enable it.
If we get more complains we might enable that part as well.

Example news post:
https://nl.hardware.info/nieuws/83024/sonyrs-dualsense-edge-ps5-controller-kost-240-euro-begin-2023-beschikbaar

OhMyGuus pushed a commit that referenced this issue Oct 25, 2022
@appeasementPolitik
Added support for hardware.info (#198)
9d31fa2 
fixes #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OhMyGuus OhMyGuus

Labels
Anonymous request Requested using the bot Website request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix nl.hardware.info appeasementPolitik/I-Dont-Care-About-Cookies
2 participants
@OhMyGuus @OhMyGuus-Bot