Generate new commons and rules with ruleclean and merge some commons #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appeasementPolitik
changed the title
|
I scanned the whole file and randomly selected urls to test, and the only mistake I could find was one of my spelling mistakes that was made while merging the commons, so in my opinion it is now merge ready. |
|
Thanks a lot this cleans it up quite well😄, will do some test tonight to see if everything is still working correctly. but it seems to be working all quite right. |
Merged
|
Thanks a lot it works perfectly, I was gone for a couple days sorry but tested it and I'm very happy with this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only needs checking if the cleaning went well before merge, but the chance is pretty low that something went wrong
Issue: #745