Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ludigoodies.com #78

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Conversation

appeasementPolitik
Copy link
Contributor

Closes #76

Please do give feedback

@OhMyGuus
Copy link
Owner

OhMyGuus commented Oct 4, 2022

Thanks for the help, contributions 👍 😄
I would of used the cookie _cookieAllowed=false here, since this banner & the CSS selector are quite generic and could be used for different things like a warning for a recall.

@OhMyGuus
Copy link
Owner

OhMyGuus commented Oct 4, 2022

Oh what a timing 😬

@appeasementPolitik
Copy link
Contributor Author

Lol, hold on still comitting the rules.json

@appeasementPolitik
Copy link
Contributor Author

Oh nevermind you also commited haha

@OhMyGuus
Copy link
Owner

OhMyGuus commented Oct 4, 2022

Oh nevermind you also commited haha

yeah I'm sorry! 😬, I moved it towards to just blocking the JS file, since its a plugin that is most likely used on other websites as well.
Thanks anyway for the contribution and the help 👍 (and sorry for finishing your PR want to release 1.0.4 today with all the fixes for websites)


oh and the cookie method was done well as well just checked it 😄

@appeasementPolitik
Copy link
Contributor Author

Haha good to hear, no worries

@OhMyGuus OhMyGuus merged commit 5e39e38 into OhMyGuus:master Oct 4, 2022
@appeasementPolitik appeasementPolitik deleted the patch-1 branch October 4, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Website request: https://ludigoodies.com/
2 participants