Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing multiple websites #9839

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fixing multiple websites #9839

merged 2 commits into from
Dec 13, 2023

Conversation

azgaresncf
Copy link
Contributor

@azgaresncf azgaresncf commented Dec 1, 2023

context

As the development of this extension is paused, by maintaining this repository, I want to contribute to it to help the developer out, even if it is going to be a tough work.

goal

  • Block as many CSS selectors as possible (temporary selectors will be changed later)
  • Otherwise, block Javascript scripts or urls
  • Otherwise, make rules with click handler (e.g : GMX) or the other handlers (e.g: Instagram, by trying to click on the popup's buttons [and then delete the cookies ???])...

uni-passau.de: fixes #2547
sunroom.it: fixes #2549
tulipsmarket.com: fixes #2550
object-carpet.com: fixes #2554
tricount.com: fixes #2555
jobware.de: fixes #2557
baden-tv.com: fixes #2560
app.outwrite.com (/!\ temp CSS selector /!\): fixes #2562
logowanie.nn.pl: fixes #2564
freizeitbad-greifswald.de: fixes #2568
linuxtechmore.com: fixes #2572, fixes #9085
it.cmlink.com: fixes #2573
dartshopper.de: fixes #2576, fixes #5133
campact.de: fixes #2578, #7899, #1520
adding lumise.se (and common serviceform CSS selector): fixes #2584
sw-lindau.de: fixes #2586
auf1.tv and auf1.info: fixes fixes #2589, fixes #2590, fixes #6091, fixes #6139, fixes #6150, fixes #6370, fixes #7003, fixes #7876, fixes #9352
@dreirund
Copy link

@azgaresncf: Since it seems that the maintainer of this, @OhMyGuus, is not active on this project anymore: Do you want to make your fork kind of "official", e.g. provide release builds and bring it to addons.mozilla.org, or at least allow for automatic update from your repository?

Regards!

@azgaresncf
Copy link
Contributor Author

@azgaresncf: Since it seems that the maintainer of this, @OhMyGuus, is not active on this project anymore: Do you want to make your fork kind of "official", e.g. provide release builds and bring it to addons.mozilla.org, or at least allow for automatic update from your repository?

Regards!

I will think about it ASAP.

@azgaresncf
Copy link
Contributor Author

azgaresncf commented Dec 13, 2023

@azgaresncf: Since it seems that the maintainer of this, @OhMyGuus, is not active on this project anymore: Do you want to make your fork kind of "official", e.g. provide release builds and bring it to addons.mozilla.org, or at least allow for automatic update from your repository?
Regards!

I will think about it ASAP.

So, I think that an (another) fork of this repo should be a good idea, but I'm getting two problems:

  1. I'm not an CSS selector expert AT ALL (even with button clicking and so on...). So any kind of help for only SOME rules may be a good option for me (even though I can block a lot of useless CSS selectors).
  2. I'm seriously questioning myself about the usefulness of this plugin, as extensions like uBlock Origin or Adguard are blocking more and more cookies pop-ups (even with the hardcore ones, such as Instagram or Google). So a lot of people should use the plugin in order to be really useful.

But the advantage is that it can make a good challenge for me, because unfortunately, the developer have made some mistakes that are (hypothetically) the reasons of why he does no longer maintain the plugin (the "Anonymous Request"...).

For the moment, I'm keeping the fork, and if you've got any ideas, please tell me.

@OhMyGuus OhMyGuus merged commit 1329da4 into OhMyGuus:master Dec 13, 2023
@dreirund
Copy link

dreirund commented Dec 13, 2023 via email

@OhMyGuus
Copy link
Owner

Moved the discussion about my inactivity to: #10278
You are fine to talk about forks or anything on that issue as well (which is pinned, I will also put an link to the issue in the readme).
Thanks a lot for the fixes for those sites, and again sorry.

@azgaresncf azgaresncf deleted the upstream/fix/filtered-websites branch December 13, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants