Profiling functionality #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow sample weight in shuffle features * add additional tag with test that fails for sample_weights
* fixed a few typos in rare categories * list when fit and nan
* add fill_value param to init() * create test_error_if_fill_value_not_permitted * fix bug * add fill_value param to relevant tests * create test_transformer_incl_fill_values_when_dividing_by_zero(). need to add logic to _div() * fix bug in test_transformer_fill_values_when_division_by_zero() * update docstring * fix bug * update unit tests * rebase branch * fix style bug * do not accept a string for . change tests accordingly. * delete fill_value when default value, None * update unit tests * fix style errors * sorted and tidied imports * reformat and added fill value to all div methods * expanded tests * fixed bug when using replace * add test to match error message --------- Co-authored-by: Morgan-Sell <[email protected]>
* paste changes on psi transformer * tidys docstrings, add detail, fix bugs * add checks for pvalue * space * black and isort * remove unnecesary intermediate variable * rephrase comment * space docstring * fix typo * fix style * add option to select all or only numerical variables, fixed number of bugs * fix style * fix type * workaround to pass general tests * expand coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-wording the contribute file.
Everything else comes from rebasing I imagine.