Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gulp serve failed #61

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tsekityam
Copy link

@tsekityam tsekityam commented Dec 2, 2017

This PR fixed three issues that makes gulp serve failure.

The issues are:

  1. Error - typescript - node_modules/@microsoft/sp-loader/node_modules/@types/react/index.d.ts(39,25): error TS1005: ',' expected.
    Reason: typescript module being used is not compatible with the @types/react module being used
    Fixed by 49c4679
    See also: types/react/index.d.ts(191,27): error TS1005: ',' expected DefinitelyTyped/DefinitelyTyped#17459

  2. Error - typescript - src/webparts/messageBar/MessageBarWebPart.ts(111,49): error TS2345: Argument of type '{ label: string; initialValue: string; inline: false; minHeight: number; mode: string; onProperty...' is not assignable to parameter of type 'IPropertyFieldRichTextBoxProps'.
    Reason: upstream introduce a new property, with is not compatible with our code.
    Fixed by c5808e1
    See also: OlivierCC/sp-client-custom-fields@0f53db7

  3. Error - typescript - src/webparts/simplePoll/components/SimplePollWebPartHost.tsx(208,15): error TS2540: Cannot assign to 'selectedValue' because it is a constant or a read-only property.
    Reason: we should not set state directly.
    Fixed by 7bb4de2
    See also: State and Lifecycle - React

The web part is incompatible with the module in version 1.3.7, because there a new property is introduced in `IPropertyFieldRichTextBoxProps`
Update state directly is not recommanded, we should use `setState()` to update state
@tsekityam
Copy link
Author

I believe my patch should also fix #48, #49 and #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant