Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predicted end time #105

Closed
chatelao opened this issue Jan 3, 2020 · 11 comments
Closed

Predicted end time #105

chatelao opened this issue Jan 3, 2020 · 11 comments
Labels
type: enhancement New feature or request
Milestone

Comments

@chatelao
Copy link

chatelao commented Jan 3, 2020

I like the predicted end-time in the telegram plug-in, which would be nice to be displayed this directly on the printer itself. Ideally with an [estimated_end_time] tag, formated in the 24 hours layout ;-).

Example: 15% until 21:03

Here the sample from Telegram (last line relevant):

telegram

@OllisGit
Copy link
Owner

OllisGit commented Jan 3, 2020

Hi @chatelao ,
thanks for this feature request. It is already on my list, see #96.

Also, I want to take a look into this plugin https://plugins.octoprint.org/plugins/PrintTimeGenius/
maybe I can include this output into the printer display as well.

@chatelao
Copy link
Author

chatelao commented Jan 3, 2020

Thank you a lot!

OllisGit added a commit that referenced this issue Jan 19, 2020
- #106, #104 switched back to upload preprocessor
- #101 increase parsing performance
- #105 NEW: ETA
- NEW: Browser-Tab-Title
@OllisGit
Copy link
Owner

Hi @chatelao,

the new version 1.17.0 include the new feature. Just put [estimated_end_time] in your message pattern.

Please test and give feedback.

Thx, in advance
Olli

@OllisGit OllisGit added status: waitingForFeedback Wating for Customers feedback and removed status: inProgress labels Jan 19, 2020
@OllisGit OllisGit added this to the V1.16.x milestone Jan 21, 2020
@TobbeJ
Copy link

TobbeJ commented Jan 21, 2020

how do you modify the date format to make more sense?
currently i use octoprint from docker and i ended up with UTC timestamp and 12h clock.
is the plugin relying on the systems own time formatting and timezone? if so perhaps the tz is wrong in the container

@OllisGit
Copy link
Owner

hi @TobbeJ,
a couple of minutes ago I just create a new issue related to the time format: #108

The current implementation use the system timezone.

Is it possible for you to change the timezone in the docker-container or do you think the plugin should allow defining a timezone for the format?

@TobbeJ
Copy link

TobbeJ commented Jan 21, 2020

i was able to fix the timezone in the docker container by adding two lines to the Dockerfile and build my own image, but i was not able to correct the wrong format of the date, it is still 12h format instead of 24h.

and one more question, when is [estimated_end_time updated] recalculated? reason for asking is that i did a short test print and end time only changed when print finished so it was a bit off.

@OllisGit OllisGit added status: analysing and removed status: waitingForFeedback Wating for Customers feedback labels Jan 26, 2020
@OllisGit
Copy link
Owner

Hi @TobbeJ ,
from my side the recalculation of the end-time is done each time "something" is changed. E.g. progress, height, layer, feedrate, etc.
But I am grabbing the "printTimeLeft-Value" from Octoprint and add the current time to it. I don't know when this value is recalculated.

The 12h/24h issue should be solved in the next release (could not tested, just implemented as described in python-doc)

@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: analysing labels Jan 28, 2020
@TobbeJ
Copy link

TobbeJ commented Jan 29, 2020

i think i was wrong about the time not updating properly.
my first test was just a short print and there probably was not enough time to update it.

i have printed a couple of much longer prints and it works fine, time gets updated now and then.
so only problem left is that the clock is in 12h instead of 24h.

@OllisGit
Copy link
Owner

Hi @chatelao, @TobbeJ ,
new Version 1.17.1 is out. The timezone and 24h is fixed (hopefully, couldn't test it. I just implemented like in the python doc).

Please test and give feedback!

Thx, in advance
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Jan 30, 2020
@chatelao
Copy link
Author

Great Feature, thank you

@TobbeJ
Copy link

TobbeJ commented Feb 3, 2020

Appears to work as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants