Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[total_height] follows the last uploaded file, NOT the file that is being printed. #220

Closed
ruedli opened this issue Mar 31, 2021 · 5 comments
Labels
type: bug Something isn't working

Comments

@ruedli
Copy link

ruedli commented Mar 31, 2021

When during a print, I upload a new job, all statistics remains as active for the printing job, however [total_height] now disdplyas the height of the NEW uploaded file, not the one that is being printed.

I see this value both in the window title bar, as on the dashboard.

Using DisplayLayerProgress 1.25.4
Octoprint:

browser.user_agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36
connectivity.connection_check: 8.8.8.8:53
connectivity.connection_ok: true
connectivity.enabled: true
connectivity.online: true
connectivity.resolution_check: octoprint.org
connectivity.resolution_ok: true
env.hardware.cores: 4
env.hardware.freq: 1500
env.hardware.ram: 1902264320
env.os.bits: 32
env.os.id: linux
env.os.platform: linux
env.plugins.pi_support.model: Raspberry Pi 4 Model B Rev 1.4
env.plugins.pi_support.octopi_version: 0.18.0
env.plugins.pi_support.throttle_state: 0x0
env.python.pip: 20.3.3
env.python.version: 3.7.3
env.python.virtualenv: true
octoprint.safe_mode: false
octoprint.version: 1.5.3
printer.firmware: Prusa-Firmware 3.9.2 based on Marlin

image

image

@ruedli ruedli changed the title [total_height] follws the last uploaded file, NOT the file that is being printed. [total_height] follows the last uploaded file, NOT the file that is being printed. Mar 31, 2021
@ruedli
Copy link
Author

ruedli commented Mar 31, 2021

I also use ARC-Welder, which processes the file during print. Not sure if this contributes to the problem

@OllisGit OllisGit added status: analysing type: bug Something isn't working labels Apr 4, 2021
@OllisGit
Copy link
Owner

OllisGit commented Apr 4, 2021

Hi @ruedli,

how do you upload the file? Via Browser Drag&Drop, Upload-Button or from Sclicer (api-call)?
fyi: Currently I could not reproduce the described issue:

  • During the print the height is not updated with the new value,
  • BUT immediately after the print is finished the total height is updated with the new value.

@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: analysing labels Apr 4, 2021
OllisGit pushed a commit that referenced this issue Apr 5, 2021
E #214: current_print_filename placeholder
B #220: total height replaced by newly uploaded file
B #182: show clock after reload
OllisGit pushed a commit that referenced this issue Apr 5, 2021
E #214: current_print_filename placeholder
B #220: total height replaced by newly uploaded file
B #182: show clock after reload
OllisGit added a commit that referenced this issue Apr 5, 2021
E #214: current_print_filename placeholder
B #220: total height replaced by newly uploaded file
B #182: show clock after reload
@OllisGit
Copy link
Owner

OllisGit commented Apr 5, 2021

Hi @ruedli,

new release 1.26.0 is out, please test and give feedback.

Thx, in advance
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Apr 5, 2021
@ruedli
Copy link
Author

ruedli commented Apr 5, 2021

Hi Olli, @OllisGit ,

I downloaded the new release, did one test and the problem seems resolved. My test sequence was:

  • Print a file with height of 6.2mm
  • While the printer is heating up: upload a file with height of 78mm. (uploaded through PrusaSlicer with "Send to printer" button)
  • The print got processed by arc-welder and was processed for its internal parameters (like filament usage). The "detailed" information, as well as the new thumbnail became visible (while the printer was still heating up).
  • The [total_height] was NOT updated, so this FIXED the issue I had seen before, where [total_height] was replaced by the value of the new uploaded file.

From my perspective it is OK now, thnx for fixing this!

The difference compared to what you were testing to reproduce, might be that unlike the default settings (which is to wait processing files until a printjob completes), I had it processed immediately during active printjobs. As mentioned this now also works as it should.

image

-edit- On a subsequent print, I uploaded new files during the first layer print and also another (non-first) layer. All was OK!

Ruedli

@ruedli ruedli closed this as completed Apr 5, 2021
@ruedli
Copy link
Author

ruedli commented Apr 5, 2021

As domumented, fixed in 1.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants