Octoprint counts all print layers twice (solved)

[sebbl2]

It seems that I am the only person with this issue.
Since the update to 1.27.1, DisplayLayerProgress shows exactly twice the number of actual layers. In Prusaslicer the layer count is still correct.
The whole thing in connection with Prusa MK3s+

Tried: Plugin uninstalled, FW MK3s reloaded

It could be related to OP 1.7, because when downgrading DLP the problem still exists.

[LUFEZ]

I have the same issue.
PrusaSlicer 2.4.0-alpha3, OctoPrint 1.7, DisplayLayerProgress Plugin 1.27.1

[OllisGit]

@sebbl2 , @sebbl2 please add a screenshot so that I have a better understanding what you mean with "twice the number".

My current assumption is that the GCODE include to many comments like this:

;LAYER_CHANGE

Please attach your uploaded gcode and also download the gcode from OP. Then I can take a look and confirm my assumption.

Thx, in advance
Olli

[sebbl2]

[sebbl2]

TestSTL_OP_vs_Prusaslicer.zip

[sebbl2]

gCodes: 1.OP 2.PS
530-11-11_Horse_body_2_FDM__repaired_0.12mm_PLA_MK3S_6h49m.gcode.txt
PS_530-11-11_Horse_body_2_FDM__repaired_0.12mm_PLA_MK3S_6h49m.gcode.txt

You seem to be right with your assumption. A lot of "Layer Change" or "M117 Indicator layer" are displayed.

[LUFEZ]

I think it is because of the [BEFORE_LAYER_CHANGE] setting in DisplayLayerProgress.
In the gcode file of PrusaSlicer are [LAYER_CHANGE] and [BEFORE_LAYER_CHANGE].
If you remove "count [;BEFORE_LAYER_CHANGE] Slic3r" in the DisplayLayerProgress settings, it counts correctly.
No idea why this was not the case before.

.

[sebbl2]

Great, that is it !! works flawlessly again. Thank you.

[sebbl2]

We should leave this open/visible to others

[OllisGit]

Hi @sebbl2 , @LUFEZ,

the last line count [;LAYER_CHANGE] Prusa was added in the last release 1.27.0 via a PullRequest.

Unfortunately I didn't know that the prusaslicer generate g-code with both comment-lines:

;LAYER_CHANGE
;Z:0.2
;HEIGHT:0.2
;BEFORE_LAYER_CHANGE
G92 E0.0

Or is that not the default behaviour of the slicer...did you add this comment lines to the gcode via custom slicer settings?

[sebbl2]

Nope, I didn't customise anything in there

[kcdr]

Same for me.
At least my PrusaSlicer (v2.3.3) emits both (;LAYER_CHANGE and ;BEFORE_LAYER_CHANGE)

[OllisGit]

Discussion from PR #238 (comment)

1. revert this pull and back out, and update docs to tell people to add BEFORE_LAYER_CHANGE to their printer profile
2. if plugin matches more than one filter use only first match (i am unclear if it does this already?)

Hi @scyto,

I think option 2 is the correct solution.

Currently the plugin scans each gcode-line agains each layer-expression. That doesn't make sense and reproduce the mentioned error.

I will change it to this behaviour: scan each gcode-line agains each layer-expression, after one expression matched it will be taken for the rest of following gcode-lines.

[OllisGit]

Hi,

now implemented in Version 1.27.2.

Please test and give me feedback

Thx, in advance
Olli

[stale]

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.