-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update landingpage.component.html To Page Scrolling. #5127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The only problem with this is that due to some other content div it seems there's always a scrollbar no matter the viewport size now. Looks like the row
in the small-middle-container
is causing it oddly enough
I'm sorry if I over-stepped. I was just trying to learn a bit myself and troubleshoot at the same time. Otherwise, I can keep poking? |
It's completely fine! Please feel free to keep poking away :) |
I believe I fixed it in commit: 18e0d90 Can you test/review and advise? |
On my desktop with a ultrawide screen at 1440p, I have no scroll bar. (I am actually using HTML for the landing page, still no issues though) |
Nice work! |
Thank you my friend, I'm happy I could learn a bit along the way and provide some assist as well! Always appreciate the work put into this project on your part! :) |
Update landingpage.component.html To Page Scrolling on mobile devices.
This is to address issue:
#5046
Tested on my mobile with success.