Use --zero-based-indices argument in Stdio and Http hosts #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue where the --zero-based-indices command line argument was not being passed along to Configuration.ZeroBasedIndices so that location/range serialization uses zero-based indices. This fix wires up the argument to configure the serializer correctly.
david-driscoll
approved these changes
Nov 9, 2017
|
Man, TravisCI is super slow today, looks like the build jobs timed out while the tests were running. |
|
public static field 🙄 🤐 😄 |
|
@daviwil : yeah, the OSX jobs get super-slow during US business hours. |
|
I'm going to go ahead and force merge this. It doesn't actually have conflicts with master |
|
Thanks a lot Dustin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where the --zero-based-indices command
line argument was not being passed along to Configuration.ZeroBasedIndices
so that location/range serialization uses zero-based indices. This
fix wires up the argument to configure the serializer correctly.