construct scripting workspace information directly from the ProjectInfo #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo files instead of relying on precomputed information
david-driscoll
approved these changes
Aug 28, 2018
👍 💯| { | ||
| if (a is PortableExecutableReference portableExecutableReference) | ||
| { | ||
| return portableExecutableReference.FilePath ?? portableExecutableReference.Display; |
There was a problem hiding this comment.
not at the moment, but once we support plugins to meddle with this project system it might 😃
|
Updated to ensure that everything is passing with the latest stuff |
|
I added a changelog update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1112 which we shipped but it didn't have a real test 😃
In this PR:
ProjectInfodirectly, which is most reliable way)